rxx Issue Tracker Rss Feed

Commented Issue: Rxx1.3 appears broken on with Rx2 on .NET 4 (WinXP) [24150]

davedev — Tue, 09 Apr 2013 18:42:46 GMT

When I add Rx 2.1 and Rxx 1.3 to a .NET 4.0 project in Vs2010 on WinXP I get compilation failures.
Sample main method
```

class Program
{
static void Main(string[] args)
{
var source = Observable.Empty<Unit>();
var connectable = source.Publish();
connectable.Prime<Unit>();
}
}
```
csproj snippet

```
<ItemGroup>
<Reference Include="Rxx">
<HintPath>..\..\packages\Rxx.1.3.4451.33754\lib\net40\Rxx.dll</HintPath>
</Reference>
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Reactive.Core">
<HintPath>..\..\packages\Rx-Core.2.1.30214.0\lib\Net40\System.Reactive.Core.dll</HintPath>
</Reference>
<Reference Include="System.Reactive.Interfaces">
<HintPath>..\..\packages\Rx-Interfaces.2.1.30214.0\lib\Net40\System.Reactive.Interfaces.dll</HintPath>
</Reference>
<Reference Include="System.Reactive.Linq">
<HintPath>..\..\packages\Rx-Linq.2.1.30214.0\lib\Net40\System.Reactive.Linq.dll</HintPath>
</Reference>
<Reference Include="System.Reactive.PlatformServices">
<HintPath>..\..\packages\Rx-PlatformServices.2.1.30214.0\lib\Net40\System.Reactive.PlatformServices.dll</HintPath>
</Reference>
<Reference Include="System.Xml.Linq" />
<Reference Include="System.Data.DataSetExtensions" />
<Reference Include="Microsoft.CSharp" />
<Reference Include="System.Data" />
<Reference Include="System.Xml" />
</ItemGroup>
```

and the error message is

```
Program.cs(16,13): error CS0012: The type 'System.Reactive.Subjects.IConnectableObservable`1<T0>' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Reactive, Version=1.0.10621.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.

Program.cs(16,13): error CS1928: 'System.Reactive.Subjects.IConnectableObservable<System.Reactive.Unit>' does not contain a definition for 'Prime' and the best extension method overload 'System.Reactive.Linq.Observable2.Prime<TSource>(System.Reactive.Subjects.IConnectableObservable`1<TSource>)' has some invalid arguments

Program.cs(16,13): error CS1929: Instance argument: cannot convert from 'System.Reactive.Subjects.IConnectableObservable<System.Reactive.Unit>' to 'System.Reactive.Subjects.IConnectableObservable`1<System.Reactive.Unit>'
```

I believe that the error is a hard reference to version in 1.3\source\Rxx\Rxx.csproj (ln ~190)
```

<Reference Include="System.Reactive, Version=1.0.10621.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL" Condition=" '$(Experimental)' != True ">
<HintPath>..\..\packages\Rx-Main.1.0.11226\lib\Net4\System.Reactive.dll</HintPath>
</Reference>
```
Comments: ** Comment from web user: davedev **

Hey Lee, thanks for reporting the issue and sorry for the inconvenience. I'll consider deploying a package for 2.0 in the near future.

Commented Issue: Rxx1.3 appears broken on with Rx2 on .NET 4 (WinXP) [24150]

davedev — Tue, 09 Apr 2013 18:38:38 GMT

Hey Lee, thanks for reporting the issue and sorry for the inconvenience. I'll consider deploying a package for 2.0 in the near future.

Commented Issue: Rxx1.3 appears broken on with Rx2 on .NET 4 (WinXP) [24150]

LeeCampbell — Tue, 09 Apr 2013 08:20:41 GMT

Thanks for the quick response. Apologies for not finding the linked conversation (I did have a look for realted issues for logging this).

The requirement to have vs2012 makes this a non starter (this project runs WinXP so no .NET4.5, no VS2012). Thanks anyway. I will pull the classes that we use and bring them into our local project :-(

Closed Issue: Rxx1.3 appears broken on with Rx2 on .NET 4 (WinXP) [24150]

davedev — Mon, 08 Apr 2013 17:18:19 GMT

Created Issue: Rxx1.3 appears broken on with Rx2 on .NET 4 (WinXP) [24150]

LeeCampbell — Mon, 08 Apr 2013 15:52:01 GMT

Closed Issue: documentation for .NET 4.0 not work [23938]

davedev — Mon, 18 Feb 2013 17:52:49 GMT

I've downloaded the documentation for .NET 4.0 (not experimental).

The chm is open from the viewer but it states: "Navigation of the Web page was cancelled".

All the tree on sidebar is available but if I select something, the topic is not loaded.

Giacomo
Comments: This is a security feature of Windows. It's not a problem with the .CHM file.

See this discussion for instructions:

http://social.msdn.microsoft.com/Forums/en-US/devdocs/thread/ef2b95e0-4198-4e1a-b876-314a23348b5e/

Created Issue: documentation for .NET 4.0 not work [23938]

gsscoder — Mon, 18 Feb 2013 16:55:51 GMT

Commented Feature: Split Into Multiple Assemblies (Rxx.*) [23878]

davedev — Mon, 04 Feb 2013 16:32:11 GMT

Consider splitting Rxx into multiple assemblies.

For example, split by Framework assembly:

* Rxx.Parsers.dll: Ix and Rx parsers.
* Rxx.UI.dll: User Interface-related types and extensions; e.g., ViewModel, WPF markup extensions, etc.
* Rxx.Net.dll: Network-related types and extensions; e.g., those that depend on System.Net, Smtp, Ping, Dns, Syndication, etc.
* Rxx.IO.dll: I/O-related types and extensions; e.g., those that depend on System.IO.
* Rxx.ServiceModel.dll: WCF-related types and extensions; e.g., those that depend on System.ServiceModel.
* Rxx.Data.dll: Data-related types and extensions; e.g., those that depend on System.Data and System.Data.SqlClient.
* Rxx.dll: Everything else.

Alternatively, split by tier:
* Rxx.Parsers.dll
* Rxx.Client.dll: Rxx.Net + Rxx.IO + Rxx.ServiceModel + Rxx.Data + Rxx.UI
* Rxx.Server.dll: Rxx.Net + Rxx.IO + Rxx.ServiceModel + Rxx.Data
* Rxx.dll

Alternatively, split by feature sets:
* Rxx.Parsers.dll
* Rxx.Conversion.dll: General FCL wrappers that convert events and async methods into observables; e.g., ObservableSocket, SocketExtensions, etc. Combination of Rxx.Net + Rxx.IO + Rxx.ServiceModel + Rxx.Data + Rxx.UI.
* Rxx.UI.dll: User Interface-related types; e.g., ViewModel.
* Rxx.dll: General types, operators and Factory methods.
Comments: ** Comment from web user: davedev **

Ignore previous comment.

Commented Feature: Split Into Multiple Assemblies (Rxx.*) [23878]

davedev — Mon, 04 Feb 2013 16:19:29 GMT

Consider splitting Rxx into multiple assemblies based on feature sets. For example:

* Rxx.Parsers: Ix and Rx parsers.
* Rxx.UI: User Interface-related types and extensions; e.g., ViewModel, WPF markup extensions, etc.
* Rxx.Net: Network-related types and extensions; e.g., those that depend on System.Net, Smtp, Ping, Dns, Syndication, etc.
* Rxx.IO: I/O-related types and extensions; e.g., those that depend on System.IO.
* Rxx.ServiceModel: WCF-related types and extensions; e.g., those that depend on System.ServiceModel.
* Rxx.Data: Data-related types and extensions; e.g., those that depend on System.Data and System.Data.SqlClient.
* Rxx: Everything else.
Comments: ** Comment from web user: davedev **

Alternatively, split by tier:

* Rxx.Parsers
* Rxx.Client: Rxx.UI + Rxx.Net + Rxx.IO + Rxx.ServiceModel + Rxx.Data
* Rxx.Server: Rxx.Net + Rxx.IO + Rxx.ServiceModel + Rxx.Data
* Rxx

Created Feature: Split Into Multiple Assemblies (Rxx.*) [23878]

davedev — Mon, 04 Feb 2013 16:15:53 GMT

Commented Feature: Slimmed down Mono-compatible version [23873]

davedev — Mon, 04 Feb 2013 16:01:45 GMT

Mono doesn't have a few of the assemblies you reference in your main Rxx project. Specifically it doesn't have Presentation and PresentationCore (I think I have the names right). Taking Rxx.dll and using it on Mono then produces some errors.

I added a "Slim" configuration and then just searched for all the .cs files which mentioned "Windows" outside of a comment and just surrounded the file with a "#if !Slim/#endif". This was basically all of the WPF ViewModel, Control & Command stuff. Once I built this version I was able to use it on Mono 3 just fine (the compiler even stripped the assembly references to Presentation from the output assembly for me since it saw they weren't being used).

This is just a request for you to create a similar Rxx target as part of your project. Instead of calling it "Rxx - Mono" you could even call it a "Rxx - Server Profile" or something since it is just dropping out the UI-related stuff.

An alternative that might keep the maintenance a bit easier is to move this Windows-specific UI-related stuff out of "rxx" and into a separate assembly. If someone wants it, they'd just add it alongside the rxx assembly.

Just as "RxJs" doesn't include the bindings for the different JS libraries. It is just the core Observable operators. And there are separate files to add the bindings for jQuery, Node, etc.

Thanks
Brandon
Comments: ** Comment from web user: davedev **

> looks like to be portable you have to give up Rx.PlatformServices.

No. __System.Reactive.PlatformServices__ assemblies provide platform-specific services, but Rx's core only depends on a service abstraction layer. When developing a portable library (such as Rxx-Portable) you can't reference any platform-specific features or __System.Reactive.PlatformServices__ assemblies, but when you reference a portable library in a platform-specific project, such as WPF, Windows Store, Windows Phone or Silverlight, then you should also reference the __System.Reactive.PlatformServices__ assembly for that particular platform. Rx's core will dynamically pick up the platform-specific features at runtime if the assembly is present. I believe its features generally include platform-specific optimizations for Rx's internal concurrency abstraction layer (CAL), improving the quality of schedulers and timers.

http://blogs.msdn.com/b/rxteam/archive/2012/08/15/reactive-extensions-v2-0-has-arrived.aspx

However, as mentioned, it is true that Rxx-Portable must give up public features that aren't supported by all of its target platforms in the portable library; e.g., .NET Sockets aren't supported by Windows Store apps. However, Windows Store has its own socket library, so perhaps a future version of portable libraries will support them in a portable way.

> [snip] Calling it a "Mono" version may be doing it (and Mono) a disservice.
> I just didn't have time to investigate if there was some mono-version of the Presentation assemblies.

Well, that's exactly why I'd call it Rxx-Mono. Even if Mono doesn't have its own implementation of WPF now, it may have one in the future. The Rxx-Mono project is exactly where that support would go. It's also where I'd put bug fixes and additional features that are specific to the Mono implementation.

Ultimately, Mono is just another platform like Windows Phone, Silverlight and Windows Store (portable), each of which have their own dedicated projects in Rxx.

RE: Server
I understand that referencing a single Rxx assembly on both the server and client seems wasteful, considering that each only uses a subset of the functionality offered. But the surface area of UI-related features in Rxx is pretty small, and the server-related features can be used on clients as well.

The original idea was that it's easier for people to understand and consume if it's only a single assembly. As I add more features to Rxx that may be changing.

I'll consider separating Rxx into different assemblies in the future. I'll add a new work item. But I think for Rxx 2.0 it's probably going to stay as a single assembly.

Commented Feature: Slimmed down Mono-compatible version [23873]

bman654 — Mon, 04 Feb 2013 14:35:49 GMT

Yes my change was a quick hack to get what I needed and not suitable for pushing to you.

I must admit everytime I see the Portable versions I walk away confused. It looks like to be portable you have to give up Rx.PlatformServices. I'm building a server application spread across Windows (.NET) and Linux (MONO). Using all the v4.5 server-side features like TPL, threads, sockets, etc. Rx.PlatformServices isn't really something I want to give up.

FWIW I am using this same slimmed down RXX version on our Windows server also -- no need for it to have references to UI assemblies. So it is not really specific to Mono. Calling it a "Mono" version may be doing it (and Mono) a disservice. I just didn't have time to investigate if there was some mono-version of the Presentation assemblies.

If it will help, I can give you a list of the .cs files I "cut" to make this version.

Closed Issue: ObservableSocket.Accept() triggers OnError after accepting the first client connection [23871]

davedev — Mon, 04 Feb 2013 13:26:46 GMT

When you subscribe to ObservableSocket.Accept() with a count > 1, the OnError event is observed immediately after the first OnNext event. This is a regression from Rxx 1.1.4197.

I am using current source (compiled against Rx 2).

Here is a unit test showing the error. Apologies for the low quality of the test, but I've been upgrading our project from a rather old version of Rx and Rxx and it took me 3+ hours to realize my unit tests were failing due to this bug rather than an intentional change in Rx 2.0 behavior.

```
[Test]
public void CanAcceptMultipleConnections()
{
var listenAddress = new IPEndPoint(IPAddress.Loopback, 12346);

using (var disposables = new CompositeDisposable())
{
Exception error = null;
int numClients = 0;
var subscription = new SingleAssignmentDisposable();
disposables.Add(subscription);
subscription.Disposable = ObservableSocket.Accept(listenAddress.AddressFamily, SocketType.Stream, ProtocolType.Tcp, listenAddress, 100)
.Subscribe(s =>
{
disposables.Add(s);
++numClients;
},
e => error = e);

using (var client = new Socket(listenAddress.AddressFamily, SocketType.Stream, ProtocolType.Tcp))
{
Assert.DoesNotThrow(() => client.Connect(listenAddress), "1st attempt");
Thread.Sleep(TimeSpan.FromSeconds(1));
}

Console.WriteLine("Error = " + ((error == null) ? "none" : error.Message));
Console.WriteLine("Connected Socket Count = " + numClients);
Console.Out.Flush();
Assert.IsNull(error, "No error should be thrown");
Assert.AreEqual(1, numClients);
}
}
```

Here is the output of the unit test:

```
Error = AcceptSocket: The socket must not be bound or connected.
Connected Socket Count = 1

No error should be thrown
Expected: null
But was:

at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)
at Shell.EP.Cdis.Network.MessageSocket.Implementation.Test.BinaryMessageSocketTest.CanAcceptMultipleConnections() in BinaryMessageSocketTest.cs: line 135
```
Comments: Fixed for Rxx 2.0.

Reopened Issue: ObservableSocket.Accept() triggers OnError after accepting the first client connection [23871]

davedev — Mon, 04 Feb 2013 13:25:34 GMT

Closed Issue: ObservableSocket.Accept() triggers OnError after accepting the first client connection [23871]

davedev — Mon, 04 Feb 2013 13:24:55 GMT

Commented Task: Rxx for Rx 2.0 [22363]

davedev — Mon, 04 Feb 2013 12:34:52 GMT

<p>Support the new Rx 2.0 release. Upgrade the Rxx solution to VS 2012. Target .NET 4.5, Metro, Silverlight 5 and Windows Phone 7.1.</p>
Comments: ** Comment from web user: davedev **

Support for Windows Store apps is now checked into source control under the "Main" folder. It's part of the Rxx-Portable .NET 4.5 project.

Note that Rxx 2.0 is still under active development and is not ready to be released yet.

Commented Feature: Slimmed down Mono-compatible version [23873]

davedev — Mon, 04 Feb 2013 11:42:43 GMT

Actually, portable Rxx is also missing some other components, such as socket extensions. So it's not exactly the same.

I'll consider adding an Rxx-Mono project and eliminate just the UI features. (I'd prefer a separate project rather than a symbol so that the output can be built by the build system as is without having to do multiple passes on the primary project.)

Commented Issue: Slimmed down Mono-compatible version [23873]

davedev — Mon, 04 Feb 2013 11:36:39 GMT

Thanks for reporting this issue.

What you describe is similar to the Rxx-Portable 4.5 project, which targets .NET 4.5 and Windows Store. Mostly it's the same as the main Rxx project but without any UI features. Does that work on Mono?

Created Issue: Slimmed down Mono-compatible version [23873]

bman654 — Mon, 04 Feb 2013 05:40:56 GMT

Mono doesn't have a few of the assemblies you reference in your main Rxx project. Specifically it doesn't have Presentation and PresentationCore (I think I have the names right). Taking Rxx.dll and using it on Mono then produces some errors.

I added a "Slim" configuration and then just searched for all the .cs files which mentioned "Windows" outside of a comment and just surrounded the file with a "#if !Slim/#endif". This was basically all of the WPF ViewModel, Control & Command stuff. Once I built this version I was able to use it on Mono 3 just fine.

This is just a request for you to create a similar Rxx target as part of your project. Instead of calling it "Rxx - Mono" you could even call it a "Rxx - Server Profile" or something since it is just dropping out the UI-related stuff.

An alternative that might keep the maintenance a bit easier is to move this Windows-specific UI-related stuff out of "rxx" and into a separate assembly. If someone wants it, they'd just add it alongside the rxx assembly.

Just as "RxJs" doesn't include the bindings for the different JS libraries. It is just the core Observable operators. And there are separate files to add the bindings for jQuery, Node, etc.

Thanks
Brandon

Commented Issue: ObservableSocket.Accept() triggers OnError after accepting the first client connection [23871]

bman654 — Sun, 03 Feb 2013 03:45:35 GMT

Here's a diff that seems to resolve the issue

```
--- a/3rdParty/Rxx-70579/Main/Source/Rxx/System/Net/Sockets/ObservableSocket - Accept.cs
+++ b/3rdParty/Rxx-70579/Main/Source/Rxx/System/Net/Sockets/ObservableSocket - Accept.cs
@@ -36,7 +36,11 @@ namespace System.Net.Sockets
var e = new SocketAsyncEventArgs();

return Observable
- .Defer(() => socket.AcceptObservable(e))
+ .Defer(() =>
+ {
+ e.AcceptSocket = null;
+ return socket.AcceptObservable(e);
+ })
.Select(r => r.AcceptSocket)
.Repeat(count);
});
```